Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade dependency of Amundsen-gremlin #473

Merged

Conversation

AndrewCiambrone
Copy link
Contributor

@AndrewCiambrone AndrewCiambrone commented Apr 12, 2021

Signed-off-by: Andrew Ciambrone andrjc4@vt.edu

Summary of Changes

Upgrades the amundsen gremlin dependency.

Tests

Upgrades dependency. I don't feel tests are needed.

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Andrew Ciambrone <andrjc4@vt.edu>
Signed-off-by: Andrew Ciambrone <andrjc4@vt.edu>
@feng-tao
Copy link
Member

CI fails

@feng-tao
Copy link
Member

@AndrewCiambrone hopefully the CI will be fixed by #476 (work in local)

@feng-tao
Copy link
Member

@AndrewCiambrone could you rebase as #476 is merged?

@feng-tao feng-tao merged commit d3aaded into amundsen-io:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants