feat: Add mysql staleness removal task #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahithi03
requested review from
allisonsuarez,
dikshathakur3119,
feng-tao and
jinhyukchang
as code owners
|
the delta extractor CI error is not related. I will take a look. |
|
@sahithi03 could you rebase the pr given #476 is now merged? this should fix the CI error. |
Signed-off-by: Sahithi Velma <sahithiv@wepay.com>
sahithi03
force-pushed
the
mysql-staleness-removal-task
branch
from
878b035
to
25cfd56
Compare
|
cc @crazy-2020 |
|
It looks good to me👍 |
feng-tao
approved these changes
Apr 17, 2021
| DRY_RUN: False, | ||
| ENGINE_ECHO: False}) | ||
|
|
||
| def __init__(self) -> None: |
There was a problem hiding this comment.
No not needed, will update 👍
Signed-off-by: Sahithi Velma <sahithiv@wepay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sahithi Velma sahithiv@wepay.com
Summary of Changes
Adds a stale data removal task for mysql metadata store
Tests
Added unit tests for the mysql_staleness_removal_task
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test