Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update redshift_metadata_extractor to extract external schema #479

Merged
merged 1 commit into from Apr 17, 2021
Merged

Conversation

jackgene
Copy link
Contributor

This updated the redshift_metadata_extractor to extract external schema as well as internal ones.

amundsen-io/amundsen#1002

Summary of Changes

Include a summary of changes then remove this line

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@jackgene
Copy link
Contributor Author

Hey guys,
I've made several attempts to sign off my last commit, but GitHub doesn't seem happy. Please let me know what I need to do.

Thanks!

@feng-tao
Copy link
Member

@jackgene I think it requires all the commits to be sign, could you squash all the commits into single one and then sign on that commit? thanks

@jackgene
Copy link
Contributor Author

@jackgene I think it requires all the commits to be sign, could you squash all the commits into single one and then sign on that commit? thanks

Thanks for getting back to me so quickly, Tao! I'll give it a try!

…well as local schema.

Signed-off-by: Jack Leow <jleow@goodrx.com>
@feng-tao feng-tao merged commit f346776 into amundsen-io:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants