fix: Switch to discovery api for mode spaces #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngyjd
requested review from
allisonsuarez,
dikshathakur3119,
feng-tao and
jinhyukchang
as code owners
youngyjd
changed the title
Signed-off-by: Junda Yang <youngyjd@gmail.com>
Signed-off-by: Junda Yang <youngyjd@gmail.com>
youngyjd
force-pushed
the
switch-to-discovery-api-for-mode-spaces
branch
from
e981b8d
to
467e961
Compare
dorianj
approved these changes
Apr 22, 2021
| # Spaces | ||
| params = {'auth': HTTPBasicAuth(conf.get_string(MODE_ACCESS_TOKEN), | ||
| conf.get_string(MODE_PASSWORD_TOKEN))} | ||
| # mode_bearer_token must be provided in the conf |
There was a problem hiding this comment.
Is this different from the normal api token? If so, could you document it in the config?
There was a problem hiding this comment.
Mode provides two kind of authentication. discovery api requires bearer token while the main api requires user password. see
feng-tao
approved these changes
Apr 22, 2021
|
I think we should eventually change all the existing mode API to use the new discovery API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting spaces from Mode main API always hang and sometimes errorred out. We were suggested by Mode to integrate to the new Discovery API for getting Mode spaces