Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Tableau icon to fe #616

Merged
merged 1 commit into from Aug 26, 2020
Merged

feat: add Tableau icon to fe #616

merged 1 commit into from Aug 26, 2020

Conversation

feng-tao
Copy link
Member

Signed-off-by: feng-tao fengtao04@gmail.com

Summary of Changes

Given amundsen-io/amundsendatabuilder#333 is merged, add tableau icon to FE repo.

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

Signed-off-by: feng-tao <fengtao04@gmail.com>
@feng-tao
Copy link
Member Author

hey @ccarterlandis @alevene, let me know if we are ready to ship this change. Thanks for the great work!

Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alevene
Copy link

alevene commented Aug 26, 2020

@feng-tao Looks great! Thanks for putting this in!

@feng-tao feng-tao merged commit ebdcc0a into master Aug 26, 2020
@feng-tao feng-tao deleted the tfeng_add_tableau branch August 26, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants