Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swagger docs don't align with common entity #283

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

allisonsuarez
Copy link
Contributor

Signed-off-by: Allison Suarez Miranda asuarezmiranda@lyft.com

Summary of Changes

Trying to fix field cannot be null issue

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@codecov-io
Copy link

Codecov Report

Merging #283 (2bff0e9) into master (2752492) will increase coverage by 3.41%.
The diff coverage is 72.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   74.10%   77.51%   +3.41%     
==========================================
  Files          25       27       +2     
  Lines        1255     1379     +124     
  Branches      136      163      +27     
==========================================
+ Hits          930     1069     +139     
+ Misses        297      263      -34     
- Partials       28       47      +19     
Impacted Files Coverage Δ
metadata_service/api/popular_tables.py 100.00% <ø> (ø)
metadata_service/api/system.py 66.66% <ø> (ø)
metadata_service/api/user.py 100.00% <ø> (ø)
metadata_service/proxy/statsd_utilities.py 81.25% <ø> (ø)
metadata_service/util.py 100.00% <ø> (ø)
metadata_service/api/column.py 54.54% <28.57%> (-45.46%) ⬇️
metadata_service/proxy/shared.py 28.57% <28.57%> (ø)
metadata_service/api/badge.py 61.29% <61.29%> (ø)
metadata_service/proxy/neo4j_proxy.py 71.55% <61.53%> (-3.45%) ⬇️
metadata_service/proxy/base_proxy.py 67.07% <73.33%> (-0.07%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6178d60...2bff0e9. Read the comment docs.

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
This reverts commit 9e7e2c3.

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez marked this pull request as ready for review March 17, 2021 22:57
@allisonsuarez allisonsuarez requested a review from a team as a code owner March 17, 2021 22:57
@allisonsuarez allisonsuarez merged commit db33af9 into master Mar 17, 2021
@allisonsuarez allisonsuarez deleted the asm-null-col-issue branch March 17, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants