Initial refactoring #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
samaloney
commented
Apr 25, 2020
samaloney
commented
- Now works on some data obatained from vso
- Removed some repeated code
- Formating and imports
* Now works on some data obatained from vso * Removed some repeated code * Formating and imports
PaulJWright
approved these changes
Apr 25, 2020
* Might work on windows now * Sperate CLI from funcions * Docstrings * Pass config as dict * Address lint and format warnings and errors
|
So further updates also see comments on this PR |
samaloney
commented
Apr 26, 2020
| if instrument == 'mdi': | ||
| run = 'checkpoints/mdi/20200312194454_HighResNet_RPRCDO_SSIMGradHistLoss_mdi_19' | ||
| run_dir = Path('checkpoints/mdi/20200312194454_HighResNet_RPRCDO_SSIMGradHistLoss_mdi_19') |
There was a problem hiding this comment.
Should alway try to use pathlib.Path for all paths in general also if we want this work on window is is a must.
samaloney
commented
Apr 26, 2020
| @@ -14,7 +14,5 @@ torch==1.1.0 | |||
| torchvision==0.3.0 | |||
| tensorboard==1.14.0 | |||
| tensorboardX==1.8 | |||
| gitpython==3.1.0 | |||
| tensorflow==1.15.2 | |||
There was a problem hiding this comment.
Should remove any other used requirements
There was a problem hiding this comment.
should there be a python requirement in here?
samaloney
commented
Apr 26, 2020
|
|
||
| from source.utils import disable_warnings, get_logger | ||
|
|
||
| disable_warnings() | ||
| logger = get_logger(__name__) | ||
|
|
||
|
|
||
| def map_prep(file, instrument, *keyward_args): |
There was a problem hiding this comment.
kwargs weren't used
samaloney
commented
Apr 26, 2020
| header['RSUN_REF'] = 696000000 | ||
|
|
||
| # Adding distance to header |
There was a problem hiding this comment.
removed currently unused/supported instruments
samaloney
commented
Apr 26, 2020
| @@ -383,21 +294,20 @@ def plot_magnetogram(amap, file, scale=1, vmin=-2000, vmax=2000, cmap=plt.cm.get | |||
| ppxx = pxx / fszh # Horizontal size of each panel in relative units | |||
| ppxy = pxy / fszv # Vertical size of each panel in relative units | |||
| ppadv = padv / fszv # Vertical padding in relative units | |||
| ppadv2 = padv2 / fszv # Vertical padding in relative units | |||
| # Never used so commented out | |||
There was a problem hiding this comment.
these are not ever used I would delete them but no totally sure what they are for?
samaloney
commented
Apr 26, 2020
|
|
||
| # Detecting need for rescale | ||
| if rescale and np.abs(1 - (map.meta['cdelt1']/0.504273)/upscale_factor) > 0.01: | ||
| map = scale_rotate(map, target_factor=upscale_factor) | ||
| if self.rescale and np.abs(1 - (amap.meta['cdelt1']/0.504273) / self.upscale_factor) > 0.01: |
There was a problem hiding this comment.
This is a bit of a magic number not totally sure what we are doing here I would suggest
- create a constant at the top for the file and reference that or
- since this is a class put it in the
__init__with a default value and document it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.