Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Testimonial Image Section #446

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

NarendraKoya999
Copy link

@NarendraKoya999 NarendraKoya999 commented Jun 22, 2023

Description

  • Update Image Option in data.json and testimonial.js in Testimonial Component attached with Testimonial Message, Testimonial Name and Testimonial Role
  • Added Profile-person Icon in separate testimonialImg Sub-Folder in Images Parent Folder
  • That added Image placed in image key section in data.json File

Pull Request Checklist

Please make sure that your PR meets the following requirements:

  • The app is working correctly after applying the changes.
  • The app is responsive and displays properly on different screen sizes and devices.
  • The changes are thoroughly documented in the appropriate files or documentation sections.
  • The coding conventions and style guidelines are followed consistently.

Checklist

Please check all applicable boxes and provide any additional information if needed.

  • I have tested the changes locally and ensured that the app is functioning as expected.
  • I have verified that the app is responsive and looks good on various screen sizes and devices.
  • I have reviewed the documentation and ensured that it accurately reflects the changes made.
  • I have followed the coding conventions and style guidelines defined in the project.
  • I have run the automated tests and all of them pass.
  • I have considered the performance implications of the changes made.
  • I have considered the security implications of the changes made.
  • I have checked for any potential regressions or side effects caused by the changes.
  • I have performed a self-review of my code.
  • Starred the repository.
  • Added My Name to the Contributor's List.
  • Followed the repository's Contributing Guidelines.
  • I ran the app and tested it locally to verify that it works as expected.

Screenshots - If Any (Optional)

Additional Notes(Optional)

Please provide any additional information or context that may be helpful for reviewing the pull request.

Related Issues

Please list any related issues or pull requests that are associated with this pull request.
Closes Issue No < #434 >

Reviewers

Please Check and Review my Pull Request with adding Images @anmode and add Respective Label Levels.

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-amupedia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2023 8:01am

@github-actions
Copy link

Thank you, @NarendraKoya999, for creating this pull request and contributing to GitHub-ReadMe! 💗

Our review team will thoroughly review the pull request and will reach out to you soon! 😇
Please make sure you have marked all the completed tasks as done. ✅
We appreciate your patience and contribution! 😀

@Harshil-Jani
Copy link
Collaborator

@NarendraKoya999 Hey sorry for the late review.
As I can see on the site. It doesn't look pretty. I would suggest you to add a dummy photo instead of keeping the strings blank since it just made it look unattractive as in screenshot below.

image

@NarendraKoya999
Copy link
Author

@NarendraKoya999 Hey sorry for the late review.
As I can see on the site. It doesn't look pretty. I would suggest you to add a dummy photo instead of keeping the strings blank since it just made it look unattractive as in screenshot below.

image

Ok @Harshil-Jani

@NarendraKoya999
Copy link
Author

NarendraKoya999 commented Jul 15, 2023

@Harshil-Jani . With your Suggested Changes, I made that work related to this PR. But, I think website has Lazy Loading and CSS Conflicts Problems. Because of, I will try again and again and that Profile Image is not visible along with Testimonial Name and Testimonial Role

@NarendraKoya999
Copy link
Author

Hi @Harshil-Jani . Please Give Me Update about this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 This is label for GirlScript Summer of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants