Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our service aligned properly #543

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

aman-kumar29
Copy link

@aman-kumar29 aman-kumar29 commented Jul 17, 2023

Description

#519
Made changes in Home_Module.css file and made the alignment of the our services setion proper and responsive.

Pull Request Checklist

Please make sure that your PR meets the following requirements:

  • The app is working correctly after applying the changes.
  • [x]The app is responsive and displays properly on different screen sizes and devices.
  • The changes are thoroughly documented in the appropriate files or documentation sections.
  • The coding conventions and style guidelines are followed consistently.

Checklist

Please check all applicable boxes and provide any additional information if needed.

  • I have tested the changes locally and ensured that the app is functioning as expected.
  • I have verified that the app is responsive and looks good on various screen sizes and devices.
  • I have reviewed the documentation and ensured that it accurately reflects the changes made.
  • I have followed the coding conventions and style guidelines defined in the project.
  • I have run the automated tests and all of them pass.
  • I have considered the performance implications of the changes made.
  • I have considered the security implications of the changes made.
  • I have checked for any potential regressions or side effects caused by the changes.
  • I have performed a self-review of my code.
  • Starred the repository.
  • Added My Name to the Contributor's List.
  • Followed the repository's Contributing Guidelines.
  • I ran the app and tested it locally to verify that it works as expected.

Screenshots - If Any (Optional)

Additional Notes(Optional)

Please provide any additional information or context that may be helpful for reviewing the pull request.

Related Issues

Please list any related issues or pull requests that are associated with this pull request.

Reviewers

Please tag the relevant team members or reviewers who should review this pull request.

Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
Signed-off-by: Aman Kumar <99892898+aman-kumar29@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
project-amupedia ✅ Ready (Inspect) Visit Preview Jul 17, 2023 3:13pm

@github-actions
Copy link

Thank you, @aman-kumar29, for creating this pull request and contributing to GitHub-ReadMe! 💗

Our review team will thoroughly review the pull request and will reach out to you soon! 😇
Please make sure you have marked all the completed tasks as done. ✅
We appreciate your patience and contribution! 😀

@github-actions github-actions bot added the gssoc23 This is label for GirlScript Summer of Code label Jul 17, 2023
@aman-kumar29
Copy link
Author

@anmode I have created pr with develop branch as suggested. Kindly go through it.

@Harshil-Jani
Copy link
Collaborator

@aman-kumar29 Thanks for the contribution. But I would prefer this PR to be on hold for sometime. Reason is complex that we had some different code which had some issues with mobile view and thus we reverted a PR which affected. So with that if you check current HEAD of develop branch then it does not consist of the Boxes on top of Our Services cards. Which means we may not actually need resizing on top of that. Extremely sorry for the confusion tho.

Currently in your preview it is looking really nice but if you would rebase on top of develop branch then you would probably see what I am saying about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 This is label for GirlScript Summer of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants