Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact form submission error fixed #576

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BhavinRaichura
Copy link

@BhavinRaichura BhavinRaichura commented Jul 24, 2023

Description

This pull request addresses the following issues:

  1. Fixed a bug in the form validation code within the form submit handler of the contact form. The bug was causing the form validation process to malfunction, leading to unsuccessful form submissions. This fix ensures that the form validation works correctly, allowing successful form submissions.
  2. Resolved a bug in the API that was not working as expected. The API is now fixed and functioning properly, ensuring that requests to the API return the expected responses.

Pull Request Checklist

Please make sure that your PR meets the following requirements:

  • The app is working correctly after applying the changes.
  • The app is responsive and displays properly on different screen sizes and devices.
  • The changes are thoroughly documented in the appropriate files or documentation sections.
  • The coding conventions and style guidelines are followed consistently.

Checklist

Please check all applicable boxes and provide any additional information if needed.

  • I have tested the changes locally and ensured that the app is functioning as expected.
  • I have verified that the app is responsive and looks good on various screen sizes and devices.
  • I have reviewed the documentation and ensured that it accurately reflects the changes made.
  • I have followed the coding conventions and style guidelines defined in the project.
  • I have run the automated tests and all of them pass.
  • I have considered the performance implications of the changes made.
  • I have considered the security implications of the changes made.
  • I have checked for any potential regressions or side effects caused by the changes.
  • I have performed a self-review of my code.
  • Starred the repository.
  • Added My Name to the Contributor's List.
  • Followed the repository's Contributing Guidelines.
  • I ran the app and tested it locally to verify that it works as expected.

Screenshots - If Any (Optional)

contact form
successful submission message
Response in console

Additional Notes(Optional)

  1. Fixed a bug in the form validation code within the form submit handler of the contact form.

    • The form validation process was malfunctioning, causing unsuccessful form submissions.
    • The fix ensures that the form validation works correctly, allowing successful form submissions.
  2. Resolved a bug in the API that was not working as expected.

    • The API was fixed and is now functioning properly.
    • Requests to the API now return the expected responses.
  3. Appropriate notification for each type of response in the form

  4. Tested the changes locally to ensure the app is functioning as expected.

    • Verified that the app works without any issues after applying the fixes.

Related Issues

[BUG] -Error submitting contact form #565

Reviewers

@tech-bash

@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-amupedia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 9:24am

@github-actions
Copy link

Thank you, @BhavinRaichura, for creating this pull request and contributing to GitHub-ReadMe! 💗

Our review team will thoroughly review the pull request and will reach out to you soon! 😇
Please make sure you have marked all the completed tasks as done. ✅
We appreciate your patience and contribution! 😀

@github-actions github-actions bot added the gssoc23 This is label for GirlScript Summer of Code label Jul 24, 2023
@tech-bash
Copy link
Collaborator

Great work! But instead of prepending a notification image maybe you can have a checked image. And try to make the UI kind of like more mature .. Rest all looks fine. Thank you!

@BhavinRaichura
Copy link
Author

Sure I will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 This is label for GirlScript Summer of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants