coursepages #645
coursepages #645
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you, @Vanshika-73, for creating this pull request and contributing to GitHub-ReadMe! 💗 Our review team will thoroughly review the pull request and will reach out to you soon! 😇 |
WalkthroughWalkthroughThe recent updates bring significant enhancements to avatar generation, course links, and UI styling across various components and pages. These changes include adding avatar color and initial generation functions, updating course links for better navigation, commenting out unnecessary image properties, and incorporating new styling dependencies. Moreover, new components for different engineering branches and MBBS courses have been introduced, enriching the display and interaction experience with the curriculum. Changes
Poem
Tip New Features and ImprovementsReview SettingsIntroduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. AST-based InstructionsCodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation. Community-driven AST-based RulesWe are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information. New Static Analysis ToolsWe are continually expanding our support for static analysis tools. We have added support for Tone SettingsUsers can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:
Revamped Settings PageWe have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to Miscellaneous
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
public/images/btech/food.jpgis excluded by!**/*.jpgpublic/images/home/mbbs.jpegis excluded by!**/*.jpeg
Files selected for processing (25)
- components/Curriculum/SubjCard.js (1 hunks)
- components/common/Navbar.js (1 hunks)
- data/semData.js (1 hunks)
- package.json (1 hunks)
- pages/courses/btech/ChemicalEngineering/index.js (1 hunks)
- pages/courses/btech/CivilEngineering/[subject].js (1 hunks)
- pages/courses/btech/CivilEngineering/index.js (1 hunks)
- pages/courses/btech/ComputerEngineering/[subject].js (1 hunks)
- pages/courses/btech/ComputerEngineering/index.js (1 hunks)
- pages/courses/btech/EceEngineering/[subject].js (1 hunks)
- pages/courses/btech/EceEngineering/index.js (1 hunks)
- pages/courses/btech/ElectricalEngineering/[subject].js (1 hunks)
- pages/courses/btech/ElectricalEngineering/index.js (1 hunks)
- pages/courses/btech/ElectronicsEngineering/[subject].js (1 hunks)
- pages/courses/btech/ElectronicsEngineering/index.js (1 hunks)
- pages/courses/btech/FoodEngineering/[subject].js (1 hunks)
- pages/courses/btech/FoodEngineering/index.js (1 hunks)
- pages/courses/btech/MechanicalEngineering/[subject].js (1 hunks)
- pages/courses/btech/MechanicalEngineering/index.js (1 hunks)
- pages/courses/btech/index.js (6 hunks)
- pages/courses/mbbs/index.js (1 hunks)
- pages/index.js (1 hunks)
- styles/Btech.module.css (2 hunks)
- styles/Home.module.css (1 hunks)
- styles/scss/sems.module.scss (1 hunks)
Files not reviewed due to errors (7)
- pages/courses/btech/CivilEngineering/[subject].js (no review received)
- pages/courses/btech/ComputerEngineering/[subject].js (no review received)
- pages/courses/btech/EceEngineering/[subject].js (no review received)
- pages/courses/btech/ElectricalEngineering/[subject].js (no review received)
- pages/courses/btech/ElectronicsEngineering/[subject].js (no review received)
- pages/courses/btech/FoodEngineering/[subject].js (no review received)
- pages/courses/btech/MechanicalEngineering/[subject].js (no review received)
Files skipped from review due to trivial changes (6)
- components/common/Navbar.js
- data/semData.js
- pages/courses/mbbs/index.js
- styles/Btech.module.css
- styles/Home.module.css
- styles/scss/sems.module.scss
Additional comments not posted (8)
components/Curriculum/SubjCard.js (2)
8-26: The implementation ofstringToColorfunction looks good and follows best practices for handling bitwise operations with eslint.
28-35: ThestringAvatarfunction is well-implemented, making good use of thestringToColorfunction for dynamic avatar styling.pages/courses/btech/ComputerEngineering/index.js (1)
6-50: Component setup and structure appear correct forComputerEngineering.The component is appropriately named and structured for the
ComputerEngineeringdirectory. Good use of modular imports and clear JSX structure.package.json (1)
17-17: Verify the usage of@mui/materialin the project to ensure it's necessary.Verification successful
The verification confirms that
@mui/materialis used in the project, specifically in thecomponents/Curriculum/SubjCard.jsfile.
components/Curriculum/SubjCard.js:import Avatar from '@mui/material/Avatar';Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `@mui/material` in the project. # Test: Search for the library usage. Expect: At least one occurrence. rg --type javascript '@mui/material'Length of output: 71
Script:
#!/bin/bash # Description: Verify the usage of `@mui/material` in the project. # Test: Search for the library usage. Expect: At least one occurrence. rg --type js '@mui/material' rg --type jsx '@mui/material' rg --type ts '@mui/material' rg --type tsx '@mui/material'Length of output: 399
Script:
#!/bin/bash # Description: Verify the usage of `@mui/material` in the project. # Test: Search for the library usage. Expect: At least one occurrence. rg '@mui/material' --glob '*.js' rg '@mui/material' --glob '*.jsx' rg '@mui/material' --glob '*.ts' rg '@mui/material' --glob '*.tsx'Length of output: 657
Script:
#!/bin/bash # Description: Verify the usage of `@mui/material` in the project. # Find all relevant files and search for the library usage. fd -e js -e jsx -e ts -e tsx -x rg '@mui/material' {}Length of output: 98
pages/courses/btech/index.js (2)
26-33: Verify the necessity of commenting out these links. If they are no longer needed, consider removing them to clean up the code.Also applies to: 34-42
Line range hint
44-135: Verify the correctness and functionality of the newly added course links to ensure they lead to the intended pages.pages/index.js (2)
183-183: The update from "B.Tech" to "B.Tech/B.E" in the link text is a good clarification.
187-190: The addition of the "M.B.B.S" link is a valuable expansion of the course offerings.
package.json
Outdated
| @@ -8,10 +8,13 @@ | |||
| "lint": "next lint" | |||
| }, | |||
| "dependencies": { | |||
| "@emotion/react": "^11.11.4", | |||
There was a problem hiding this comment.
Tip
Codebase Verification
The search for @emotion/react only found its entry in package.json and no actual usage in the codebase. This suggests that the dependency might be unnecessary.
- Please verify if
@emotion/reactis indeed required or if it can be removed to avoid unnecessary bloat.
Analysis chain
Verify the usage of @emotion/react in the project to ensure it's necessary.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the usage of `@emotion/react` in the project.
# Test: Search for the library usage. Expect: At least one occurrence.
rg --type javascript '@emotion/react'
Length of output: 72
Script:
#!/bin/bash
# Description: Verify the usage of `@emotion/react` in the project.
# Test: Search for the library usage. Expect: At least one occurrence.
rg --type js '@emotion/react'
Length of output: 29
Script:
#!/bin/bash
# Description: Verify the usage of `@emotion/react` in the project.
# Test: Search for the library usage in .js, .jsx, and .tsx files. Expect: At least one occurrence.
rg --type-add 'jsx:*.{jsx,tsx}' '@emotion/react'
Length of output: 95
package.json
Outdated
| @@ -8,10 +8,13 @@ | |||
| "lint": "next lint" | |||
| }, | |||
| "dependencies": { | |||
| "@emotion/react": "^11.11.4", | |||
| "@emotion/styled": "^11.11.5", | |||
There was a problem hiding this comment.
Tip
Codebase Verification
The dependency @emotion/styled is not used in the codebase and may be unnecessary.
package.json: Line 12
Analysis chain
Verify the usage of @emotion/styled in the project to ensure it's necessary.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the usage of `@emotion/styled` in the project.
# Test: Search for the library usage. Expect: At least one occurrence.
rg --type javascript '@emotion/styled'
Length of output: 73
Script:
#!/bin/bash
# Description: Verify the usage of `@emotion/styled` in the project.
# Test: Search for the library usage. Expect: At least one occurrence.
rg --type js '@emotion/styled'
Length of output: 30
Script:
#!/bin/bash
# Description: Verify the usage of `@emotion/styled` in the project.
# Test: Search for the library usage in JavaScript and TypeScript files. Expect: At least one occurrence.
rg --type-add 'js:*.{js,jsx,ts,tsx}' '@emotion/styled'
Length of output: 102
There was a problem hiding this comment.
why you added these two packages.. are they really required?
There was a problem hiding this comment.
@anmode, the analysis indicates that both @emotion/react and @emotion/styled are listed in the package.json but are not actively used in any JavaScript or TypeScript files within the project. This suggests that these packages might have been added unnecessarily.
It's a good practice to keep the project dependencies minimal to reduce the bundle size and potential maintenance overhead. You might want to verify if these packages are planned to be used in future developments. If not, consider removing them to keep the project clean and efficient. If you need further assistance or have plans for these packages, please let me know!
Analysis chain
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the usage of `@emotion/react` in the project.
# Test: Search for the library usage in JavaScript and TypeScript files. Expect: At least one occurrence.
rg --type-add 'js:*.{js,jsx,ts,tsx}' '@emotion/react'
Length of output: 100
| const ComputerEngineering = () => { | ||
| return ( | ||
| <div> | ||
| <Header image="/images/blog/blog_bg.svg" text="Ece Engineering" /> | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>First Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* second yr */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Second Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* third Year*/} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Third Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* fourth */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Fourth Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| <Footer /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default ComputerEngineering; |
There was a problem hiding this comment.
Ensure the component name matches the file context.
The component is named ComputerEngineering but it is used in the EceEngineering directory. This could lead to confusion and errors in maintenance. Consider renaming the component to EceEngineering to match the file context.
- const ComputerEngineering = () => {
+ const EceEngineering = () => {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const ComputerEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Ece Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; | |
| const EceEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Ece Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; |
| const ComputerEngineering = () => { | ||
| return ( | ||
| <div> | ||
| <Header image="/images/blog/blog_bg.svg" text="Food Engineering" /> | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>First Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* second yr */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Second Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* third Year*/} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Third Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* fourth */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Fourth Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| <Footer /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default ComputerEngineering; |
There was a problem hiding this comment.
Ensure the component name matches the file context.
The component is named ComputerEngineering but it is used in the FoodEngineering directory. This could lead to confusion and errors in maintenance. Consider renaming the component to FoodEngineering to match the file context.
- const ComputerEngineering = () => {
+ const FoodEngineering = () => {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const ComputerEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Food Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; | |
| const FoodEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Food Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; |
| const ComputerEngineering = () => { | ||
| return ( | ||
| <div> | ||
| <Header image="/images/blog/blog_bg.svg" text="Civil Engineering" /> | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>First Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* second yr */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Second Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* third Year*/} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Third Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* fourth */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Fourth Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| <Footer /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default ComputerEngineering; |
There was a problem hiding this comment.
Ensure the component name matches the file context.
The component is named ComputerEngineering but it is used in the CivilEngineering directory. This could lead to confusion and errors in maintenance. Consider renaming the component to CivilEngineering to match the file context.
- const ComputerEngineering = () => {
+ const CivilEngineering = () => {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const ComputerEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Civil Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; | |
| const CivilEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Civil Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; |
| const ComputerEngineering = () => { | ||
| return ( | ||
| <div> | ||
| <Header image="/images/blog/blog_bg.svg" text="Chemical Engineering" /> | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>First Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* second yr */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Second Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* third Year*/} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Third Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* fourth */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Fourth Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| <Footer /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default ComputerEngineering; |
There was a problem hiding this comment.
Ensure the component name matches the file context.
The component is named ComputerEngineering but it is used in the ChemicalEngineering directory. This could lead to confusion and errors in maintenance. Consider renaming the component to ChemicalEngineering to match the file context.
- const ComputerEngineering = () => {
+ const ChemicalEngineering = () => {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const ComputerEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Chemical Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; | |
| const ChemicalEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Chemical Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; |
| const ComputerEngineering = () => { | ||
| return ( | ||
| <div> | ||
| <Header image="/images/blog/blog_bg.svg" text="Electrical Engineering" /> | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>First Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* second yr */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Second Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* third Year*/} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Third Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* fourth */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Fourth Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| <Footer /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default ComputerEngineering; |
There was a problem hiding this comment.
Ensure the component name matches the file context.
The component is named ComputerEngineering but it is used in the ElectricalEngineering directory. This could lead to confusion and errors in maintenance. Consider renaming the component to ElectricalEngineering to match the file context.
- const ComputerEngineering = () => {
+ const ElectricalEngineering = () => {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const ComputerEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Electrical Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; | |
| const ElectricalEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Electrical Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; |
| const ComputerEngineering = () => { | ||
| return ( | ||
| <div> | ||
| <Header image="/images/blog/blog_bg.svg" text="Mechanical Engineering" /> | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>First Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* second yr */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Second Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* third Year*/} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Third Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* fourth */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Fourth Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| <Footer /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default ComputerEngineering; |
There was a problem hiding this comment.
Ensure the component name matches the file context.
The component is named ComputerEngineering but it is used in the MechanicalEngineering directory. This could lead to confusion and errors in maintenance. Consider renaming the component to MechanicalEngineering to match the file context.
- const ComputerEngineering = () => {
+ const MechanicalEngineering = () => {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const ComputerEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Mechanical Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; | |
| const MechanicalEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Mechanical Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; |
| const ComputerEngineering = () => { | ||
| return ( | ||
| <div> | ||
| <Header image="/images/blog/blog_bg.svg" text="Electronics Engineering" /> | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>First Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* second yr */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Second Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* third Year*/} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Third Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| {/* fourth */} | ||
| <div | ||
| data-aos='fade-up' | ||
| className={styles.ourserv} | ||
| id={styles.ourserv} | ||
| > | ||
| <h2>Fourth Year</h2> | ||
| /</div> | ||
| <Sems data={firstYearSems} /> | ||
| <Footer /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default ComputerEngineering; |
There was a problem hiding this comment.
Ensure the component name matches the file context.
The component is named ComputerEngineering but it is used in the ElectronicsEngineering directory. This could lead to confusion and errors in maintenance. Consider renaming the component to ElectronicsEngineering to match the file context.
- const ComputerEngineering = () => {
+ const ElectronicsEngineering = () => {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const ComputerEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Electronics Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; | |
| const ElectronicsEngineering = () => { | |
| return ( | |
| <div> | |
| <Header image="/images/blog/blog_bg.svg" text="Electronics Engineering" /> | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>First Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* second yr */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Second Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* third Year*/} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Third Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| {/* fourth */} | |
| <div | |
| data-aos='fade-up' | |
| className={styles.ourserv} | |
| id={styles.ourserv} | |
| > | |
| <h2>Fourth Year</h2> | |
| /</div> | |
| <Sems data={firstYearSems} /> | |
| <Footer /> | |
| </div> | |
| ); | |
| }; | |
| export default ComputerEngineering; |
|
Please look at code rabbit ai once. I'll provide my reviews at today night asap |
components/Curriculum/SubjCard.js
Outdated
| // import InitialsAvatar from /'react-initials-avatar'; | ||
| // import 'react-initials-avatar/lib/ReactInitialsAvatar.css'; | ||
|
|
||
|
|
||
| function stringToColor(string) { | ||
| let hash = 0; | ||
| let i; | ||
|
|
| export const firstYearSems = [ | ||
| { | ||
| name: null, | ||
| subjects: [ | ||
| { | ||
| name: "Applied Mathematics 1", | ||
| slug: "applied-mathematics-1", | ||
| img: null, | ||
| // img:( ), |
There was a problem hiding this comment.
because I have used Initials Avatar for the subjects.
package.json
Outdated
| @@ -8,10 +8,13 @@ | |||
| "lint": "next lint" | |||
| }, | |||
| "dependencies": { | |||
| "@emotion/react": "^11.11.4", | |||
| "@emotion/styled": "^11.11.5", | |||
There was a problem hiding this comment.
why you added these two packages.. are they really required?
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (11)
- components/Curriculum/SubjCard.js (1 hunks)
- package.json (1 hunks)
- pages/courses/bcom/index.js (1 hunks)
- pages/courses/bsc/index.js (1 hunks)
- pages/courses/btech/ChemicalEngineering/index.js (1 hunks)
- pages/courses/btech/CivilEngineering/index.js (1 hunks)
- pages/courses/btech/EceEngineering/index.js (1 hunks)
- pages/courses/btech/ElectricalEngineering/index.js (1 hunks)
- pages/courses/btech/ElectronicsEngineering/index.js (1 hunks)
- pages/courses/btech/FoodEngineering/index.js (1 hunks)
- pages/courses/btech/MechanicalEngineering/index.js (1 hunks)
Files skipped from review due to trivial changes (2)
- pages/courses/bcom/index.js
- pages/courses/bsc/index.js
Files skipped from review as they are similar to previous changes (9)
- components/Curriculum/SubjCard.js
- package.json
- pages/courses/btech/ChemicalEngineering/index.js
- pages/courses/btech/CivilEngineering/index.js
- pages/courses/btech/EceEngineering/index.js
- pages/courses/btech/ElectricalEngineering/index.js
- pages/courses/btech/ElectronicsEngineering/index.js
- pages/courses/btech/FoodEngineering/index.js
- pages/courses/btech/MechanicalEngineering/index.js
|
@anmode I have pushed the required changes in the branch I made. |
#630
Different pages are added for different courses. I have changed few pictures wherever I found. I added an MBBS course, whereas I combined B.tech and BE.
As this task was related to frontend, I haven't added notes, links and different subject names for different courses.