Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make mpi optional for amuse-framework #521

Merged
merged 6 commits into from Nov 1, 2019

Conversation

ipelupessy
Copy link
Member

this needs to be tested

@ipelupessy
Copy link
Member Author

not sure this is the correct approach..with the current configure it does not matter if MPI with or without mpi4py is installed, AMUSE will be correctly configured and functional for the environment..maybe we should just drop the mpi4py requirement for all packages (and maybe make a seperate package amuse-mpi for this?)..the only reason not to do this is that we also use mpi4py as a sort of check for the presence of MPI...

@ipelupessy
Copy link
Member Author

it would be nice to have amusifier report what MPI functionality the installation has...

@ipelupessy
Copy link
Member Author

now only amuse-framework has the option of being pip installed w/o mpi4py...

@ipelupessy
Copy link
Member Author

if you install non-mpi with mpi available, but w/o mpi4py and add mpi4py later, the MPI channel will work
if you do while mpi is not available, installing mpi4py will not enable MPI channel

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #521 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   81.36%   81.36%           
=======================================
  Files         130      130           
  Lines       39359    39359           
=======================================
  Hits        32024    32024           
  Misses       7335     7335

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e84fee...5705e98. Read the comment docs.

@ipelupessy
Copy link
Member Author

ok, I don't think we need codecov report here!!

@rieder
Copy link
Member

rieder commented Oct 31, 2019 via email

@ipelupessy
Copy link
Member Author

I think this PR might actually work...

@ipelupessy
Copy link
Member Author

but it is nice that codecov works..I looked at the report and it reports detailed info, can be very handy

@rieder
Copy link
Member

rieder commented Oct 31, 2019

yes I think so too. I've now disabled the comments, but it'll still work.

Copy link
Member

@rieder rieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to the changes here, but packages/amuse/pyproject.toml should not have versions hardcoded, ideally...

@rieder rieder merged commit 1ae8f6b into amusecode:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants