New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make mpi optional for amuse-framework #521
Conversation
not sure this is the correct approach..with the current configure it does not matter if MPI with or without mpi4py is installed, AMUSE will be correctly configured and functional for the environment..maybe we should just drop the mpi4py requirement for all packages (and maybe make a seperate package amuse-mpi for this?)..the only reason not to do this is that we also use mpi4py as a sort of check for the presence of MPI... |
it would be nice to have amusifier report what MPI functionality the installation has... |
now only amuse-framework has the option of being pip installed w/o mpi4py... |
if you install non-mpi with mpi available, but w/o mpi4py and add mpi4py later, the MPI channel will work |
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 81.36% 81.36%
=======================================
Files 130 130
Lines 39359 39359
=======================================
Hits 32024 32024
Misses 7335 7335 Continue to review full report at Codecov.
|
ok, I don't think we need codecov report here!! |
No that seems a bit much...
|
I think this PR might actually work... |
but it is nice that codecov works..I looked at the report and it reports detailed info, can be very handy |
yes I think so too. I've now disabled the comments, but it'll still work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to the changes here, but packages/amuse/pyproject.toml should not have versions hardcoded, ideally...
this needs to be tested