Remote workers for socket channel #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r local running tbd: dynamic python worker codes, debug support
rieder
reviewed
Apr 10, 2023
src/amuse/rfi/channel.py
Outdated
| @@ -35,8 +35,9 @@ | |||
| from amuse.support.options import OptionalAttributes, option, GlobalOptions | |||
| from amuse.support.core import late | |||
| from amuse.support import exceptions | |||
| from amuse.support import get_amuse_root_dir | |||
| from amuse.support import get_amuse_root_dir, get_amuse_directory_root | |||
There was a problem hiding this comment.
these function names are easy to confuse...
There was a problem hiding this comment.
yea..in amusifier its called --get-amuse-package-dir, maybe thats better?
There was a problem hiding this comment.
get-amuse-package-root?
There was a problem hiding this comment.
prob consistency is best..
rieder
reviewed
Apr 10, 2023
rieder
reviewed
Apr 10, 2023
rieder
reviewed
Apr 10, 2023
|
@ipelupessy could you include an example of how to use this? Otherwise it looks good to me. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
rieder
removed
the
stale
rieder
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows workers to be started remotely using sockets_channel under the following conditions: