Multiples module merge #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to smalln to dump orbit information to a file for closer study.
Modified smalln and multiples independent of amuse base.
mutually unbound if over = 1, and to use a weaker perturbation criterion to create a usable tree structure when over = 3. Modified smalln interface to allow trajectory plotting data to be saved in a file. Added global debugging flag to multiples.py. Fine-tuned choices of length and time scales to limit long-lived encounters, and improved handling of long-lived multiples through several encounters. Corrected bug in the compression of many-body systems that created spurious bound pairs. Added code to check the integrity of the tree structure. Corrected bug in scale_top_level_list that left leaves inconsistent with top-level nodes and caused center of mass errors. Created experimental code to monitor the quadrupole contribution to the tidal potential error.
Updating local version.
checkpointing and restart.
a nearby star exceeds the distance limit.
…nances. Better debugging.
|
here it breaks a test in test/codes_tests/test_smalln.py and most of test/codes_tests/test_multiples.py |
|
Sorry, I missed this. I'll take a look at the tests. Are you OK with me changing them? |
|
See my e-mail. I have fixed the smallN issue, but the multiples problem is deeper. |
|
so encounters needs to be updated? I willopen an issue report for this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substantial bug fixes and improvements to multiples algorithms. Greatly improved accuracy and stability.