Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove set_acceleration from all interfaces #994

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

rieder
Copy link
Member

@rieder rieder commented Oct 5, 2023

fixes #862

@rieder rieder requested review from a team as code owners October 5, 2023 08:27
Copy link

stale bot commented Dec 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Dec 4, 2023
@stale stale bot closed this Jan 1, 2024
@rieder rieder reopened this Jan 1, 2024
@stale stale bot removed the stale Issues that have been around for a while without updates label Jan 1, 2024
Copy link

stale bot commented Mar 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Mar 1, 2024
@LourensVeen
Copy link
Collaborator

I'm not sure if I'm supposed to be reviewing PRs, but why not? Maybe we should discuss that actually, what the process is that we're using.

There's a bit of context missing from the description, but I'm guessing from the comment in community/interface/gd.py that this was physically unsound, and is therefore being removed?

I'm seeing a few more files with set_acceleration in them that should probably be updated too:

  • src/amuse/community/mpiamrvac/interface.py
  • src/amuse/community/mpiamrvac/interface.t
  • src/amuse/test/suite/core_tests/test_bridge.py
  • src/amuse/test/suite/codes_tests/test_mpiamrvac.py
  • doc/tutorial/simplegrav/interface_1.cc
  • doc/reference/stellar_dynamics_interface_specification.rst

@stale stale bot closed this Mar 31, 2024
@rieder rieder removed the stale Issues that have been around for a while without updates label Mar 31, 2024
@rieder rieder reopened this Mar 31, 2024
@rieder
Copy link
Member Author

rieder commented Apr 24, 2024

I'm not sure if I'm supposed to be reviewing PRs, but why not? Maybe we should discuss that actually, what the process is that we're using.

There's a bit of context missing from the description, but I'm guessing from the comment in community/interface/gd.py that this was physically unsound, and is therefore being removed?

Yes, that's correct. The codes will always overwrite the acceleration, so setting this is misleading.

I'm seeing a few more files with set_acceleration in them that should probably be updated too:

* `src/amuse/community/mpiamrvac/interface.py`

* `src/amuse/community/mpiamrvac/interface.t`

* `src/amuse/test/suite/core_tests/test_bridge.py`

* `src/amuse/test/suite/codes_tests/test_mpiamrvac.py`

In these cases it seems to be used in a different way, maybe needs to be addressed but that would be a different PR.

* `doc/tutorial/simplegrav/interface_1.cc`

* `doc/reference/stellar_dynamics_interface_specification.rst`

Updated.

@rieder rieder merged commit 1773e56 into amusecode:main Apr 24, 2024
5 checks passed
@rieder rieder deleted the patch_remove_set_acc branch April 24, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove set_acceleration from gd.py
2 participants