Pass the vr_use_immersive_mode as a Vertex Shader Uniform flag #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means the same shaders can be used for both immersive and non-immersive as the uniform itself it the toggle in the GLSL rather than generating two different instances of the shader. Furthermore, only one place where the gl_Position was being modified was actually needed; the other two seem to be able to be removed without it preventing immersive mode from working.
|
Looks great! Thanks so much! |
|
maybe we should just pass the immersion_factor in as the uniform? then we could have the low/high res mode your original version had |
|
Sure!, I'll take a look at that. Using the uniforms like this might also be a way of either adding in the "adaptive screen" functionality that some people have mentioned.. but one step at a time. I'll make the additional change to restore the alternative immersive modes. |
|
Have you checked the layout of the uniform structure is correct? bools are padded to 4 bytes under the std140 layout rules. The previous one worked cause the client side struct was padded as well, but now that you added another one, they are packed. You can add an alignas(4) to the client side if not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means the same shaders can be used for both immersive and non-immersive as the uniform itself is the toggle in the GLSL rather than generating two different instances of the shader.
Furthermore, only one place where the gl_Position was being modified was actually needed; the other two seem to be able to be removed without it preventing immersive mode from working.
Hopefully this change will help make it easier to merge immersive to the main branch as it will now longer cause shader cache issues for anyone.