Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another little thing I've been experimenting with. This PR adds the modern style ProgressRing control to FA!
Previous attempts have run into issues with performance around this. This version shifts the animation over the Composition thread which should significantly help with that, and keep the progress ring running smoothly even if the UI thread slows for whatever reason. Thus, the actual attempt is done directly with Skia and will require the Skia rendering backend.
WinUI's AnimatedVisualPlayer (Lottie) also runs on the composition thread, so behavior should basically be identical. I wasn't able to make sense of the generated Lottie AnimatedVisualSource for WinUI's progress ring, so this attempt is entirely reverse engineered by watching the animation - it seems close enough to me.
Media1.mp4