Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bson implementation #4

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Bson implementation #4

merged 8 commits into from
Feb 22, 2024

Conversation

KantaiKessen
Copy link
Contributor

Implementation of encapsulate and reveal functions in the bson module, as well as a single unit test.

KantaiKessen and others added 7 commits February 6, 2024 13:13
Initial implementation of encapsulate for bson module. Unit test created as well.

Signed-off-by: Kevin Liu <kevin.liu@csu.fullerton.edu>
The encapsulate function was rewritten in order to have the correct parameters and return type.

Signed-off-by: Kevin Liu <kevin.liu@csu.fullerton.edu>
The reveal function was implemented. It takes a byte vector and returns a Result<PacketVersion, std::io::Error>.

Signed-off-by: Kevin Liu <kevin.liu@csu.fullerton.edu>
Remade the acc structure. This is because the previous structure did not do well with serialization into bson.

Signed-off-by: Kevin Liu <kevin.liu@csu.fullerton.edu>
rewrote the reveal function in order to function properly with the new bson implementation.

Signed-off-by: Kevin<kevin.liu@csu.fullerton.edu>
formatted code

Signed-off-by: Kevin<kevin.liu@csu.fullerton.edu>
Copy link
Owner

@amyipdev amyipdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good - have a few questions but no changes requested so far, almost ready to merge

src/bson.rs Outdated Show resolved Hide resolved
src/bson.rs Show resolved Hide resolved
src/bson.rs Outdated Show resolved Hide resolved
Signed-off-by: Amy Parker <amy@amyip.net>
Copy link
Owner

@amyipdev amyipdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amyipdev amyipdev merged commit 7b35a92 into amyipdev:main Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants