Fix pushbullet device_iden parameter. #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rget_device_iden. Signed-off-by: jesopo <github@lolnerd.net>
amyreese
added a commit
that referenced
this pull request
Feb 19, 2016
Fix pushbullet device_iden parameter.
|
Thanks! |
|
Hi there, this pull seems to make pushbullet send to all my devices instead of the set target, I've reverted the change and now everything works as it's supposed to. Not sure if there was an API change again or this never worked as intended? |
|
Looks like the API documentation agrees that the parameter should just be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems pushbullet at some point changed the parameter from device_iden to target_device_iden, this is a commit to fix it.