Move constants in InferenceParameters into ParameterDict #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meissnereric could you look into the reason that the test cases fail? |
|
Yeah sure, they passed locally for me. |
|
Appears to be an issue in how MXNet differs in Python 3.4/5 from 3.6 which changes the gradient calculations of Constants. This is probably why only the ScoreFunction tests break since they're the only ones where we numerically check gradients. I can replicate it by running the tests in Python 3.4/5, and reverting the Constant changes make the tests pass again. |
|
Could we identify which API of mxnet changes behaviors between 3.4/3.5 and 3.6? |
zhenwendai
reviewed
Feb 15, 2019
Co-Authored-By: meissnereric <meissner.eric.7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Shift MXNet based constants from being stored in the InferenceParameters._constants dictionary (which still exists and keeps scalar/native constants) to keeping MXNet constants in the ParameterDict where other Parameters are kept.
This removes the need for the separate MXNet constants file at serialization file as well!
(Feel free to ignore the documentation change here, it's a remnant of the larger docs change I made in another PR and I'll try to make sure the other one is the one that gets kept.)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.