fix(sketch): fix sketch palette format to use new filters #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a new version of the sketchpalette plugin, and I can't get the old version to work. I'm thinking to not break backwards compatibility, we could instead create a new format with 'sketch/palette/v2'? |
|
👍🏾 |
Closed
|
I agree with the idea to create a new one is probably the best path forward. The naming is something I think we'd need in Sketch Palettes, I can see no value in putting effort into the old one. Unfortunately I had to park my SD integration for the moment so can't get back to look at it this sprint. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #285
Description of changes: Removing filtering from the sketch/palette format because we handle filtering before formats now.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.