Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced gpyopt with emukit #60

Merged
merged 4 commits into from Jun 25, 2019
Merged

Replaced gpyopt with emukit #60

merged 4 commits into from Jun 25, 2019

Conversation

apaleyes
Copy link
Contributor

Issue #, if available:

Description of changes: We are phasing out gpyopt in favor of emukit. This PR replaces gpyopt with emukit in xfer-hpo notebook.

This PR replaces #59 which was done against a wrong branch

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@apaleyes apaleyes closed this Jun 21, 2019
@apaleyes apaleyes reopened this Jun 21, 2019
@apaleyes
Copy link
Contributor Author

New build error is caused by emukit installation hiccup. I'll fix that and update the PR

Copy link
Contributor

@jnkm jnkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.

Have you run the 2 parameter optimisation to confirm that it performs as expected?

@apaleyes
Copy link
Contributor Author

I did for the original PR, but for this one I just assumed it still works. Tuned out merge butchered that as well, so had to do a few fixes. Thanks for vigilance!

@jnkm jnkm merged commit 86ae4e3 into amzn:develop Jun 25, 2019
jnkm added a commit that referenced this pull request Jan 14, 2020
* Add brackets to predict prob docstring

* Remove i.e. from predict prob docstring

* Update requirements link

* Add link to feature request template in contributing doc (#29)

* Update links to feature request template

* Correct typo

* Update documentation

* additional -> all

* Move GPy to be with other 3P imports

* Remove 'i.e.' from predict docstring

* Add fullstops

* Add full stops to module docstrings

* Remove doc dependency

* Add missing word to save_repurposer docstring

* Demo transfer learning for text categorization

* change kernel to default

* Address pull request comments

* Remove plot from hpo notebook because of gpyopt error

* Include plot_acquistion command as markdown code with links to open issues

* Linux build trusty->xenial. Notebook tests osx->linux

* brew->sudo apt-get

* Add Gluon notebooks

* Execute missed cells

* Remove pip update

* Update pip on macosx

* Updated README

* Remove hpo notebook from travis build

* Bump version: 0.3.6 → 1.0.0

* Add back hpo notebook to travis build

* Kernel xfer-env to python3

* Remove "language: generic"

* Separate gluon demos in travis to avoid timeout

* Fix typo: 'filename'->filename

* Fix bug: gluon notebooks being tested twice

* Run gluon notebook tests on linux

* Show more modelhandler features in demo

* Speed up hpo notebook test using latest linux machines

* Rerun notebook

* Update kernel name

* Replace emist letters dataset with mnist

* Catch modified error string

* Add jupyter libraries to test requirements file

* Limit version of Tornado to <6

* Leap (#51)

* Add leap files

* Add copyright notices

* Fix flake8 formatting

* Fixing missing label in parameter plot

* Fix relative imports

* Address commits

* Add indent to branch (#52)

* Add short description to the Leap's demo (#53)

* Add short description to the Leap's demo

* Update xfer/contrib/xfer_leap/demos/multitask_leap.ipynb

Co-Authored-By: pgmoren <pgmoren@gmail.com>

* Update xfer/contrib/xfer_leap/demos/multitask_leap.ipynb

Co-Authored-By: pgmoren <pgmoren@gmail.com>

* Update xfer/contrib/xfer_leap/demos/multitask_leap.ipynb

Co-Authored-By: pgmoren <pgmoren@gmail.com>

* Update xfer/contrib/xfer_leap/demos/multitask_leap.ipynb

Co-Authored-By: pgmoren <pgmoren@gmail.com>

* Bump version: 1.0.0 → 1.1.0 (#54)

* Remove scipy docs requirement (#56)

* Fix prob_base load bug (#58)

* Replaced gpyopt with emukit (#60)

* Replaced gpyopt with emukit

* Fixes for the merge

* Fixes to 2 param case

* Update tests for new releases of dependencies (#61)

* Update tests for new releases of dependencies (e.g mxnet==1.5.0)

* Fix line length

* Bump version: 1.1.0 → 1.2.0

* Add comments about expected accuracy

Co-authored-by: Keerthana Elango <40637405+palindromik@users.noreply.github.com>
Co-authored-by: pgmoren <pgmoren@gmail.com>
Co-authored-by: Andreas Damianou <adamianou@gmail.com>
Co-authored-by: Andrei Paleyes <apaleyes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants