[WIP] Handle blocks of assembly/il code. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jdpage
commented
Jun 25, 2018
•
jdpage
commented
- Extract useful/relevant code from this into a new PR
- Close this PR
As part of this, some nodes that were previously custom classes became AstNodes. In particular, the entire gold.storage module is gone, along with gold.passes.asm.AsmRun. As an additional advantage, some compiler passes which were previously imperative are now pattern-based.
The point of this is to be able to include position information when parsing s-expressions. Additionally, this should make the IL deserializer that much simpler.
jdpage
added a commit
that referenced
this pull request
Aug 9, 2018
In particular, the entire jeff65.gold.storage module is gone, along with jeff65.gold.passes.asm.AsmRun. As an additional advantage, some compiler passes which were previously imperative are now pattern-based. (This was rescued from PR #37 asm-blocks, where it was mixed in with a bunch of other changes.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.