Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses python-shell-interpreter instead of hardcoded "python" #12

Closed
wants to merge 1 commit into from
Closed

Conversation

furkanusta
Copy link

Fixes #10

Although the fix is general and should work for ipython as well, I didn't test ipython as I only use python3 currently. (It was working for ipython at the time I submitted this PR before)

@anachronic
Copy link
Owner

I took a look at this and it seems to work ok as long as you don't set more than one single-string argument at a time. For example: if python-shell-interpreter-args is "--arg1 --arg2", importmagic will fail. I see the need for this and I'll implement it probably this weekend.

The readme you provided is kind of misleading and leads to fail when trying to use ipython. From what i understand, python-shell-interpreter-args is supposed to be a single string and not a list of strings. This is what causing importmagic to fail, because epc expects a list of strings.

As I said, I'll do it this weekend and I'll also provide some testing for it. Thanks for the contribution, though. I'll be closing this once everything is fixed.

@anachronic
Copy link
Owner

#15 is opened for officially closing this issue. If you could try it out (branch devel), please leave comments in #14.

@anachronic anachronic closed this May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find importmagic and epc
2 participants