Move variables/services/downloads to be per-env-spec #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables includes downloads and services. This is a breaking semantic change, plus publication_info JSON change and method signature change. No real way around that...
This will let us associate the variables with the env specs
At the moment, the lists are all the same; we don't parse per-env-spec variables yet. But this commit pretends that we did.
This adds env_spec_name param to project_ops for variables, and a --env-spec option to the command line subcommands. There's a trick that variables are actually per-env-prefix (well, keyring vars are and local state file vars aren't, but that's something of a bug). This means we need to prepare to see what the env prefix is. Adopted this policy: - can pass in a prepare_result when doing set/unset/remove - use env prefix from prepare result when provided - otherwise, do a prepare to get env prefix. For set, do the prepare in dev mode so we will create the env if missing; for unset, use check mode and error if not already created; for remove, use check mode and silently don't unset if not already created. This approach needs to be copied to downloads and services, next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when setting variables in local state file, allow per-env-spec valuesdeferred to Allow per-env-spec local variable values #80This is for #52
This will be a breaking change, both API/JSON-wise and semantically.