-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host kernel not detected; all others OK #113
Comments
Same/similar here. while my $ conda env list (py37)
# conda environments:
#
base /Users/klay6683/miniconda3
isis3 /Users/klay6683/miniconda3/envs/isis3
py2 /Users/klay6683/miniconda3/envs/py2
py36 /Users/klay6683/miniconda3/envs/py36
py37 * /Users/klay6683/miniconda3/envs/py37
vpython /Users/klay6683/miniconda3/envs/vpython I don't understand why VPython appears twice? And my py37 host is missing as well.
The lack of |
That's right. |
So this raises an interesting UX question. The kernel in the "host" environment is there; it just doesn't follow the naming convention the other kernels are given. The only kernels in the Putting the "host" environment back would eliminate the confusion, at the expensive of redundancy--the host kernel would appear twice in the list, under different names. I'm open to that, especially if someone else makes the PR :-) but I wonder if it ought to be optional. |
@mcg1969 , In Under It looks like you changed the behavior in 25dcca8. Would it be acceptable to revert to the previous behavior of including the host env in the dict of environments? I haven't dug into the code far enough to understand how environments are excluded: if a UI mod is needed that's probably over my head. |
Indeed, I think y'all are right—the duplication in the kernel list is better than the confusion. We can even, say, put some sort of indicator into the format noting the current environment. I'm open to a PR on this, and at some point I'll take a look. |
I would have been a big time saver to include this change of behavior in the list of breaking changes. I know multiple people beside myself who have been scratching their heads over this bug. The sooner you can push the new version the better. |
When launching
jupyter notebook
from a conda env running Python 3.7 and nb_conda_kernels 2.2.0, the notebook fails to identify the kernel of host environment from which Jupyter was launched. [edit: this behavior also found using Python 3.6 build in 3.6 env].Using
conda-forge::nb_conda_kernels=2.1.1=py36_1001
in a Python 3.6 env gives expected behavior: all kernels are available.Similar problem to #112 (comment) but I think this is different from #112.
Example 0
Jupyter file browser opens; click on
![py37](https://user-images.githubusercontent.com/6756310/48233412-e5b95600-e369-11e8-95c0-809476a4553b.png)
New
s37
) available but not the hostpy37
Example 1
Equivalent result when I activate a different Python 3.7 env and launch
jupyter notebook
:The
![py37_version](https://user-images.githubusercontent.com/6756310/48233634-d555ab00-e36a-11e8-9d92-3218b0ce9e7b.png)
py37
env from the previous example is visible and operable.Versions (both 3.7 envs)
conda info --all
The text was updated successfully, but these errors were encountered: