Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Int overflow on 32 bits arches #16

Closed
eclipseo opened this issue Jul 3, 2019 · 1 comment
Closed

Int overflow on 32 bits arches #16

eclipseo opened this issue Jul 3, 2019 · 1 comment

Comments

@eclipseo
Copy link

eclipseo commented Jul 3, 2019 •
edited
Loading

Golang 1.12.6 on i686 and armv7

Testing    in: /builddir/build/BUILD/missinggo-2.1.0/_build/src
         PATH: /builddir/build/BUILD/missinggo-2.1.0/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/missinggo-2.1.0/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X github.com/anacrolix/missinggo/version=2.1.0 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: github.com/anacrolix/missinggo
github.com/anacrolix/missinggo
PASS
ok  	github.com/anacrolix/missinggo	0.007s
github.com/anacrolix/missinggo/bitmap
FAIL	github.com/anacrolix/missinggo/bitmap [build failed]
BUILDSTDERR: # github.com/anacrolix/missinggo/bitmap [github.com/anacrolix/missinggo/bitmap.test]
BUILDSTDERR: ./bitmap_test.go:91:34: constant 9223372036854775807 overflows int
anacrolix added a commit that referenced this issue Jul 26, 2019
@anacrolix
Run CI tests for 32 bit
c0ccd22 
See #16
anacrolix added a commit to anacrolix/torrent that referenced this issue Jul 26, 2019
@anacrolix
Test 32-bit arch on CircleCI
011df3d 
See anacrolix/missinggo#16
@anacrolix
Copy link
Owner

I don't know if you're using anacrolix/torrent, but I made a similar fix in https://github.com/anacrolix/torrent/releases/tag/v1.5.1.

anacrolix added a commit that referenced this issue Aug 15, 2019
@anacrolix
Run CI tests for 32 bit
39ae473 
See #16

(cherry picked from commit c0ccd22)
anacrolix added a commit that referenced this issue Aug 15, 2019
@anacrolix
Skip test assuming int is 64 bit
ebeec26 
Fixes #16.

(cherry picked from commit bfa7df3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anacrolix @eclipseo