Pieces delete issue

[YouROK]

Hi,
how do you properly delete pieces?
I have a download that goes into memory.
There is a certain cache, I open the reader, it reads and send to http.
If there are more pieces than the size of the cache, then the last read piece is released.

https://github.com/YouROK/TorrServer/blob/master/server/torr/storage/torrstor/cache.go
https://github.com/YouROK/TorrServer/blob/master/server/torr/storage/torrstor/piece.go

func (p *Piece) Release() {
	p.mu.Lock()
	defer p.mu.Unlock()
	if p.buffer != nil {
		p.buffer = nil
	}
	p.Size = 0
	p.complete = false

	p.cache.torrent.Piece(p.Id).SetPriority(torrent.PiecePriorityNone)
}

Everything is fine, until one moment, if I give these chunks a priority, it gives an error and does not upload.

Is there any way to reset the state of the piece as it was when the torrent was opened?

[vic1234]

@anacrolix
Do you have any update on this issue?

[VuzzyM]

@anacrolix ???

[anacrolix]

I'm not sure I quite understand, however if the issue is around having a limited storage cache, there are improvements in master for this now. You can provide an indication to the Client of the available storage for each torrent, or even Client, and it will try to avoid thrashing and excessive readaheads. I suspect this could help. Please try master.

[VuzzyM]

I'm not sure I quite understand, however if the issue is around having a limited storage cache, there are improvements in master for this now. You can provide an indication to the Client of the available storage for each torrent, or even Client, and it will try to avoid thrashing and excessive readaheads. I suspect this could help. Please try master.

@YouROK

[YouROK]

I use self storage with self pieces impl. In piece using mem buffer(slice) when all size of buffers is more than set in sets first buffer clean but=nil and os mem clean.

When reader seek start and begin read, client read piece as complete, but buffer is nil and completions impl sets to false. My piece return eof and client not readahead. Client read and reload torrent only in reader piece position

[VuzzyM]

I use self storage with self pieces impl. In piece using mem buffer(slice) when all size of buffers is more than set in sets first buffer clean but=nil and os mem clean.

When reader seek start and begin read, client read piece as complete, but buffer is nil and completions impl sets to false. My piece return eof and client not readahead. Client read and reload torrent only in reader piece position

@anacrolix

[anacrolix]

Client read and reload torrent only in reader piece position

I think I follow this part. On a read error, the client should try to refresh the completion state for the entire readahead window as an optimisation. I think you're suggesting that it doesn't?

It looks like it should here

torrent/reader.go

Line 236 in 9c81516

r.t.updatePieceCompletion(index)

[VuzzyM]

Client read and reload torrent only in reader piece position

I think I follow this part. On a read error, the client should try to refresh the completion state for the entire readahead window as an optimisation. I think you're suggesting that it doesn't?

It looks like it should here

torrent/reader.go

Line 236 in 9c81516

r.t.updatePieceCompletion(index)

@YouROK

[YouROK]

Client read and reload torrent only in reader piece position

I think I follow this part. On a read error, the client should try to refresh the completion state for the entire readahead window as an optimisation. I think you're suggesting that it doesn't?

It looks like it should here

torrent/reader.go

Line 236 in 9c81516

r.t.updatePieceCompletion(index)

Thx this help me in new version

[anacrolix]

Thank you for following this up.