Remove bradfitz/iter package dependency #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anacrolix
reviewed
Mar 24, 2021
| @@ -65,12 +64,12 @@ func BenchmarkPieceMarkComplete(b *testing.B, ci storage.ClientImpl, pieceSize i | |||
| } | |||
| // Fill the cache | |||
| if capacity > 0 { | |||
| for range iter.N(int((capacity + info.TotalLength() - 1) / info.TotalLength())) { | |||
| for i := 0; i < int((capacity + info.TotalLength() - 1) / info.TotalLength()); i++ { | |||
There was a problem hiding this comment.
How do we know that TotalLength won't be recomputed on every iteration now?
|
I use bradfitz/iter (and have my own clone of it) somewhat to rail against Go's lack of expressiveness. I'm not convinced it's actually inferior to the alternative given that it is less error prone, probably guarantees intermediate caching of the bounds, and seems syntactically appropriate given how you would range over a builtin container type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package github.com/bradfitz/iter was intended to be an educational joke when it was released in 2014.
It's not idiomatic to use the package and it doesn't add any significant value to readability.