Use a private SSL context for OkHttp to avoid crashing when certain other libraries are also used. #40
Conversation
… when using a library like good analytics along side OkHttp square/okhttp#184 . an alternative might be to update the okhttp library, they seemed to have finally closed the issue...
|
It looks like this is already fixed in OkHttp master, no? Would a better solution just be to move the submodule up to a later version? |
|
This is my tried and tested solution which I have found to be working reliably, but I think updating is probably a better long term solution. I will close this out. I just wanted to make sure this didn't slip through the cracks. |
|
@tpurtell Just revert your previous commit and make the submodule change in the same PR, or reset it away (you knew that you can keep committing to a PR and it'll show up here, even after submitting, riiiiiiiight?) |
|
I'm going to fix this by bumping the OkHttp version. Thanks though! |
|
I'm still hitting this crash consistently when mixing ModernHttpClient and Google Analytics. @paulcbetts, can you confirm that the latest versions were actually built with updated versions of OkHttp? This could be a red herring, but when I look at the assembly for OkHttp in ModernHttpClient v1.2.1 I see this:
|
|
@gshackles I want to die |
|
@paulcbetts please don't we still love you! |
|
This shouuuuuld be good now. Reopen if it's not |
add workaround of having a private SSL context so crashes don't occur when using a library like google analytics along side OkHttp square/okhttp#184 . an alternative might be to update the okhttp library, they seemed to have finally closed the issue...