Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item 12 From Issue #4: Setting Rise/Fall Times of Rectangular Waveforms #32

Closed
jonpearson opened this issue Nov 10, 2016 · 5 comments
Closed

Comments

@jonpearson
Copy link

Item 12 from Issue #4

"How do I set the rise / fall time of the square wave ( trapezoidal wave shape)?"

@jonpearson
Copy link
Author

This feature needs to be added. Should we change the name to "Rectangular?" Doug's indication of "trapezoidal" is the most accurate, but it's not used on traditional function generators.

@jonpearson jonpearson changed the title Item 12 From Issue #4 Item 12 From Issue #4: Setting Rise/Fall Times of Rectangular Waveforms Nov 10, 2016
@rgetz
Copy link

rgetz commented Nov 10, 2016

http://literature.cdn.keysight.com/litweb/pdf/33500-90901.pdf?id=2197440

Square waves : frequency, amplitude, offset, duty cycle, and phase

Pulse : : period, amplitude, offset, width, leading edge, trailing edge, and phase.
The edge time represents the time from the 10% threshold to the 90% threshold of each edge.

So, the function is there - it's just not called "trapezoidal", it's a pulse.

I think for what we are doing - trapezoidal is actually clearer (IHMO).

@damercer
Copy link

Everybody seems to have their own preferred names for various wave shapes. My take it that the name is less important than the functionality to control all the various aspects of the wave shape.

@adisuciu
Copy link
Contributor

Commit b267d3c implements trapezoidal waveform that allows setting rise/fall times for rectangular waveforms.

@adisuciu adisuciu added the fixed label Jan 12, 2018
@amiclaus
Copy link
Contributor

On Scopy build e9a6c85 (v0.10) the feature is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants