Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add angular 15 template (#116) #158

Merged
merged 5 commits into from Nov 20, 2022

Conversation

dalenguyen
Copy link
Contributor

@dalenguyen dalenguyen commented Nov 20, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-angular-plugin
  • astro-angular
  • create-analog
  • router

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Ability to generate Angular 15 template

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@netlify
Copy link

netlify bot commented Nov 20, 2022

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit f6f1b81
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/6379e3c55e172b00074fff9b
😎 Deploy Preview https://deploy-preview-158--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@brandonroberts brandonroberts merged commit df44122 into analogjs:main Nov 20, 2022
@brandonroberts
Copy link
Member

Thanks! @allcontributors add @dalenguyen for code

@allcontributors
Copy link
Contributor

@brandonroberts

I've put up a pull request to add @dalenguyen! 🎉

@teobmg
Copy link

teobmg commented Nov 23, 2022

Hi @brandonroberts,
I have a question about this: even if the new template has been merged, the vite plugin is still requiring version 14 of the build-angular dependency: https://github.com/analogjs/analog/blob/main/packages/vite-plugin-angular/package.json#L22

Should we open a separate PR for that?

@brandonroberts
Copy link
Member

Thanks @teobmg yes you can open a separate PR for that

Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants