Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): process/transform styles before Angular compilation #167

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-angular-plugin
  • astro-angular
  • create-analog
  • router

What is the current behavior?

  • External styles are applied globally
  • Inline styles were not being compiled

Issue Number: #142

What is the new behavior?

External/inline styles are compiled/applied correctly.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 6e3aaab
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/63852f3e0592f4000981a62d
😎 Deploy Preview https://deploy-preview-167--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 6e3aaab
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/63852f3ed2c49f000882db58
😎 Deploy Preview https://deploy-preview-167--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brandonroberts brandonroberts merged commit a2f3aa6 into main Nov 28, 2022
@brandonroberts brandonroberts deleted the fix-inline-styles branch November 29, 2022 03:28
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant