Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update prerender option to discover and resolve routes #211

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-angular-plugin
  • astro-angular
  • create-analog
  • router
  • platform
  • content

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@netlify
Copy link

netlify bot commented Jan 15, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 0c042fc
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/63c47a3b190c9f0009b92034
😎 Deploy Preview https://deploy-preview-211--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 15, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 0c042fc
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/63c47a3b490c20000999468f
😎 Deploy Preview https://deploy-preview-211--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brandonroberts brandonroberts merged commit 99a7bb2 into main Jan 16, 2023
@brandonroberts brandonroberts deleted the feat-prerender-routes branch January 16, 2023 04:16
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
analogjs#211)

BREAKING CHANGE:

The `prerender` option has been renamed to `static`, and `prerender` is now a config object to auto-discover routes to be pre-rendered, and to add support for resolving additional routes async.

BEFORE:

```js
analog({
  prerender: true
})
```

AFTER:

```js
analog({
  static: true,
  prerender: {
    discover: true,
    routes: async() => ['/', '/blog', '/extra/route']
  }
})
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant