Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] fix buttons styling on mobile #38

Closed
dalenguyen opened this issue Aug 18, 2022 · 4 comments · Fixed by #42
Closed

[DOCS] fix buttons styling on mobile #38

dalenguyen opened this issue Aug 18, 2022 · 4 comments · Fixed by #42
Assignees

Comments

@dalenguyen
Copy link
Contributor

CTA on mobile is not responsive

Current Behaviour

image

Expect Behaviour

CTA buttons should be responsive on mobile

@dalenguyen
Copy link
Contributor Author

And can I work on this ticket? 🤣

@brandonroberts
Copy link
Member

Lol yes of course. While you're in there will you update the color for the header to match on lite/dark modes. The red should be the one used in the light mode on both.

@LayZeeDK
Copy link
Contributor

LayZeeDK commented Aug 18, 2022

@brandonroberts

Lol yes of course. While you're in there will you update the color for the header to match on lite/dark modes. The red should be the one used in the light mode on both.

This is a separate concern. Please open a separate issue for this.

That being said, the red has been brightened in dark mode for accessibility WCAG-AA contrast concerns when used with black as recommended by Docusaurus.

@brandonroberts
Copy link
Member

Thanks Lars. I thought to file a new issue for this also but didn't. Good call on the accessibility front but I'd like the color to be closer to the ones in the logo. I'll file a separate issue to keep the conversation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants