-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix styling for buttons on mobile #42
docs: fix styling for buttons on mobile #42
Conversation
@brandonroberts @LayZeeDK I'm utilizing |
Good solution, @dalenguyen. I wonder how it looks if we make those CTA button links full width on small screens 🤔 |
@LayZeeDK I can target the a tag on smaller screens and make the button full with this
Then on a smaller screen, it will look like this |
Infima/Docusaurus uses a breakpoint, I believe it is 996px width. |
Visually it looks great though! |
I like the full width buttons also! |
@LayZeeDK I saw that they implement |
Makes sense! |
Add the full width style to the home page and we're good to go in my opinion 😊 |
Cool. Just applied full width to buttons on mobile :D |
@@ -20,6 +20,16 @@ | |||
display: flex; | |||
align-items: center; | |||
justify-content: center; | |||
flex-wrap: wrap; | |||
gap: 1rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Great solution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Use the Infima spacing variable instead of hard-coding 1rem
.
gap: 1rem; | |
gap: var(--ifm-global-spacing); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, great catch :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Dale! @allcontributors Please add @dalenguyen for css |
I couldn't determine any contributions to add, did you specify any contributions? |
Ok lol. @allcontributors Please add @dalenguyen for design |
I've put up a pull request to add @dalenguyen! 🎉 |
References
New Behaviour