Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-nitro): enable prerendering of root index.html #663

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

The root index.html is not prerendering unless nitro: { serveStatic: false } is set in the analog plugin. This prevents retrieving static assets during pre-rendering if needed.

Closes #585

What is the new behavior?

The root index.html is pre-rendered with the serveStatic option still being enabled if its included in the prerender routes.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit d81f715
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/650c44621990330008eab327
😎 Deploy Preview https://deploy-preview-663--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit d81f715
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/650c44623e4476000844045f
😎 Deploy Preview https://deploy-preview-663--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit d81f715
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/650c446209e4610007c9e33f
😎 Deploy Preview https://deploy-preview-663--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit c231f56 into main Sep 21, 2023
19 checks passed
@brandonroberts brandonroberts deleted the fix-prerender-index branch September 21, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: disable serving static assets by default
1 participant