-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: disable serving static assets by default #585
Comments
I can take this @brandonroberts |
Thanks @goetzrobin. Need to think on this one more. This would be a breaking change unless we write some migrations to set it to true for existing projects. Also it might break the usage of |
Then I cannot take this 😄 Thanks for pointing that out! |
It might not fit all use cases but I'm mitigating it currently by setting |
One solution is to delete the Then we would render the index.html in the public assets directory. |
This fix has been released in version |
Which scope/s are relevant/related to the feature request?
vite-plugin-nitro
Information
One issue we keep coming across is the / route not being pre-rendered. This is because there is an index.html in the client build, and Nitro uses this for serving when pre-rendering.
The workaround is to set
serveStatic: false
in the Nitro config.This change would set the flag to false by default, as normal assets would be published to the deployment providers CDN, and not served through the Nitro server.
Describe any alternatives/workarounds you're currently using
No response
I would be willing to submit a PR to fix this issue
The text was updated successfully, but these errors were encountered: