fix(create-analog): set composite to false and include ts files in ts… #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KylerJohnsonDev does this produce errors in the tsconfig.json? I thought that the composite must be true in the referenced tsconfigs. |
I don't see any errors and the app seems to build correctly. This may present issues if Vite needs to determine if the project is already built for any reason, though. I'm not sure about that. |
brandonroberts
approved these changes
Sep 3, 2022
|
Thanks! @allcontributors add @KylerJohnsonDev for code |
|
I've put up a pull request to add @KylerJohnsonDev! 🎉 |
Villanuevand
pushed a commit
to Villanuevand/analog
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #75