Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite-plugin-angular): queries work and outputs are now in metada… #852

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

nartc
Copy link
Member

@nartc nartc commented Jan 12, 2024

…ta decorator instead

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

  • Outputs are compiled to use @Output decorator
  • No support for View/Content queries

Closes #

What is the new behavior?

  • Outputs are compiled to use outputs metadata instead (no decorator)
  • View/Content queries are supported via defineMetadata
<script lang="ts">
import { ViewChild, afterNextRender, ElementRef } from '@angular/core';

defineMetadata({
  queries: {
    // 👇 declare a query for Angular Compiler
    divElement: new ViewChild('theDiv')
  }
});

//  👇 declare a variable matched with the query name to use in .ng file
let divElement: ElementRef<HTMLDivElement>;

afterNextRender(() => {
  console.log('div available', divElement);
});
</script>

<template>
  <div #theDiv>Component content</div>
</template>

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 70428cf
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/65a1d0741c4ee00008fbe049
😎 Deploy Preview https://deploy-preview-852--analog-ng-app.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 70428cf
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/65a1d074ebad36000836eb3b
😎 Deploy Preview https://deploy-preview-852--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nartc nartc self-assigned this Jan 12, 2024
Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 70428cf
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65a1d074dda6c80008fbd2f3
😎 Deploy Preview https://deploy-preview-852--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nartc nartc added the enhancement New feature or request label Jan 12, 2024
Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 70428cf
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/65a1d074af8d5600084ee9b1
😎 Deploy Preview https://deploy-preview-852--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit d081c79 into analogjs:main Jan 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants