Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-nitro): resolve internal runtime files on Windows and add Windows build workflow #949

Merged
merged 25 commits into from
Mar 22, 2024

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Mar 20, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Internal runtime files fail to resolve only on Windows, causing pre-rendering to fail. This only started surfacing after the switch over to ESM plugins.

Closes #945
Closes #931
Closes #831

What is the new behavior?

  • Files are resolved correctly, and the build and prerendering finishes
  • There is a warning/error in CI about creating a directory that already exists, but doesn't impact the output
  • Also added a GitHub workflow to build on Windows to catch future compatibility issues

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

@brandonroberts brandonroberts force-pushed the ci-windows-build branch 5 times, most recently from 343db3b to 55c010b Compare March 22, 2024 14:26
@brandonroberts brandonroberts force-pushed the ci-windows-build branch 2 times, most recently from 1546767 to 66b61bc Compare March 22, 2024 15:24
@brandonroberts brandonroberts changed the title ci: add windows build job fix: resolve internal runtime files on Windows and add Windows build workflow Mar 22, 2024
@brandonroberts brandonroberts changed the title fix: resolve internal runtime files on Windows and add Windows build workflow fix(vite-plugin-nitro): resolve internal runtime files on Windows and add Windows build workflow Mar 22, 2024
@brandonroberts brandonroberts merged commit cf5886a into beta Mar 22, 2024
8 checks passed
@brandonroberts brandonroberts deleted the ci-windows-build branch March 22, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant