-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite-plugin-nitro): resolve internal runtime files on Windows and add Windows build workflow #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
force-pushed
the
ci-windows-build
branch
from
March 20, 2024 05:26
fd94773
to
6ed6dc5
Compare
brandonroberts
force-pushed
the
ci-windows-build
branch
from
March 20, 2024 05:51
6fa7a97
to
a4bb180
Compare
brandonroberts
force-pushed
the
ci-windows-build
branch
from
March 20, 2024 14:26
483687b
to
f608832
Compare
2 tasks
brandonroberts
force-pushed
the
ci-windows-build
branch
5 times, most recently
from
March 22, 2024 14:26
343db3b
to
55c010b
Compare
brandonroberts
force-pushed
the
ci-windows-build
branch
from
March 22, 2024 15:00
55c010b
to
9805bd1
Compare
brandonroberts
force-pushed
the
ci-windows-build
branch
2 times, most recently
from
March 22, 2024 15:24
1546767
to
66b61bc
Compare
brandonroberts
force-pushed
the
ci-windows-build
branch
from
March 22, 2024 15:25
66b61bc
to
9d0bfd5
Compare
brandonroberts
changed the title
ci: add windows build job
fix: resolve internal runtime files on Windows and add Windows build workflow
Mar 22, 2024
brandonroberts
changed the title
fix: resolve internal runtime files on Windows and add Windows build workflow
fix(vite-plugin-nitro): resolve internal runtime files on Windows and add Windows build workflow
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Internal runtime files fail to resolve only on Windows, causing pre-rendering to fail. This only started surfacing after the switch over to ESM plugins.
Closes #945
Closes #931
Closes #831
What is the new behavior?
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?