fix(vite-plugin-angular): remove numbers from beginning of file name selector #952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Similar to #919
When attempting to create a component using a
.agx
file:It will fail if the file name begins with numbers, as this is used to generate a selector for the component of
01-generating-angular-app
and thencreateComponent
will try to use that as the tag name but it is invalid.What is the new behavior?
This change strips any leading numbers/hyphen from the selector generated from the file name, so
01-generating-angular-app.agx
would result in a selector ofgenerating-angular-app
This change applies to all file name based selectors not just
.agx
filesDoes this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?