Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-nitro): handle web Response object in dev server plugin #1141

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • vitest-angular
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

If a Response is returned instead of an HTML string, the development server throws an error.

Closes #

What is the new behavior?

If a Response is returned, it is handled and sent using the sendWebResponse utility method from h3 that handles headers/cookies/etc.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 85479fb
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/665df91649645a00088cce3b
😎 Deploy Preview https://deploy-preview-1141--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 85479fb
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/665df9167170e00008b5287d
😎 Deploy Preview https://deploy-preview-1141--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for analog-blog failed.

Name Link
🔨 Latest commit 85479fb
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/665df91620c64f0008ecc9af

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 85479fb
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/665df916ca13910008276346
😎 Deploy Preview https://deploy-preview-1141--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit a8b0f32 into beta Jun 3, 2024
19 of 24 checks passed
@brandonroberts brandonroberts deleted the fix-nitro-dev-response branch June 3, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant