Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-plugin): update rxjs dependency #1142

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

goetzrobin
Copy link
Member

the analogjs repo has an rxjs version of 7.8.0, we should install the same version when initializing a new nx analog workspace.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • vitest-angular
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

outdated rxjs version is installed

Closes #

What is the new behavior?

same rxjs version as in main repo is installed

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

the analogjs repo has an rxjs version of 7.8.0, we should install the
same version when initializing a new nx analog workspace.
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit d821496
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/665f03b6a89d1300089e2d63
😎 Deploy Preview https://deploy-preview-1142--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit d821496
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/665f03b68a182600089db3f6
😎 Deploy Preview https://deploy-preview-1142--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit d821496
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/665f03b6f3719d00086d21fa
😎 Deploy Preview https://deploy-preview-1142--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit d821496
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/665f03b76284600007bf9ecc
😎 Deploy Preview https://deploy-preview-1142--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit c697365 into beta Jun 4, 2024
23 of 24 checks passed
@brandonroberts brandonroberts deleted the fix-rxjs-dependency branch June 4, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants