build: convert commonjs packages to esm #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
benmccann
reviewed
Aug 9, 2023
benmccann
approved these changes
Aug 9, 2023
brandonroberts
force-pushed
the
build-esm-packages
branch
from
74d58a4
to
b40918d
Compare
an empty message aborts the commit. # # On branch build-esm-packages # Changes to be committed: # new file: apps/analog-app-e2e-cypress/package.json # new file: apps/analog-app-e2e-playwright/package.json # modified: apps/analog-app/project.json # renamed: apps/analog-app/vite.config.mts -> apps/analog-app/vite.config.ts # renamed: apps/analog-preset-e2e/vite.config.mts -> apps/analog-preset-e2e/vite.config.ts # new file: apps/astro-app-e2e-playwright/package.json # modified: apps/astro-app-e2e-playwright/tests/app.spec.ts # renamed: apps/astro-app-e2e-playwright/vite.config.mts -> apps/astro-app-e2e-playwright/vite.config.ts # new file: apps/blog-app-e2e-cypress/package.json # modified: apps/blog-app/project.json # renamed: apps/blog-app/vite.config.mts -> apps/blog-app/vite.config.ts # modified: apps/create-analog-e2e/tests/create-analog.spec.ts # renamed: apps/trpc-app/postcss.config.js -> apps/trpc-app/postcss.config.cjs # modified: apps/trpc-app/project.json # renamed: apps/trpc-app/tailwind.config.js -> apps/trpc-app/tailwind.config.cjs # renamed: apps/trpc-app/vite.config.mts -> apps/trpc-app/vite.config.ts # renamed: commitlint.config.js -> commitlint.config.cjs # modified: package.json # modified: packages/create-analog/template-angular-v16/angular.json # modified: packages/create-analog/template-angular-v16/package.json # renamed: packages/create-analog/template-angular-v16/vite.config.mts -> packages/create-analog/template-angular-v16/vite.config.ts # modified: packages/vite-plugin-nitro/src/lib/vite-plugin-nitro.ts #
brandonroberts
force-pushed
the
build-esm-packages
branch
from
4461093
to
36872e7
Compare
brandonroberts
force-pushed
the
build-esm-packages
branch
from
36872e7
to
7572318
Compare
brandonroberts
force-pushed
the
build-esm-packages
branch
from
0e4693e
to
7975ee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
The above packages are bundled as CommonJS instead of ESM
Closes #573
What is the new behavior?
Does this PR introduce a breaking change?
The above packages are bundled as ESM instead of CommonJS. In order to upgrade to this released version, the
type: modulewill need to be added to thepackage.json, which could have unintended impact across a project with multiple applications in it.Other information
[optional] What gif best describes this PR or how it makes you feel?