Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro-angular,vite-plugin-angular): update zone.js deep imports for compatibility #651

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

rlmestre
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #650

What is the new behavior?

Imports were updated to ensure compatibility with current and future versions.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 153d90e
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/6504d28b9733b00008164c52
😎 Deploy Preview https://deploy-preview-651--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 153d90e
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/6504d28b6363b30008d0a6c4
😎 Deploy Preview https://deploy-preview-651--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 153d90e
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/6504d28b54008800099053dc
😎 Deploy Preview https://deploy-preview-651--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts
Copy link
Member

Thanks @rlmestre. Will you also update the pinned version of zone.js in the package.json so we'll be on latest also

@rlmestre rlmestre force-pushed the fix/remove-zone-js-deep-import branch from 35dcb72 to 86612b4 Compare September 15, 2023 20:49
@brandonroberts
Copy link
Member

Removing this section should fix the analog-app build error
https://github.com/rlmestre/analog/blob/86612b43685f0714ea14d1ede702d9f0b8284469/packages/platform/src/lib/ssr/ssr-build-plugin.ts#L6-L14

@brandonroberts brandonroberts merged commit 704e2e9 into analogjs:main Sep 15, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: zone.js import not found in versions greater than 0.13.1
2 participants