Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default reporters to vitest configuration #791

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

If the reporters array is undefined, no reporters are added, causing the ng test command to run with no output.

Closes #

What is the new behavior?

The reporters array is set to ['default'], so terminal output is produced.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 4f9fd72
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/657714008316880008c18e03
😎 Deploy Preview https://deploy-preview-791--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 4f9fd72
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/6577140000a1400008c5eed0
😎 Deploy Preview https://deploy-preview-791--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 4f9fd72
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65771400bd857a0008b6d13a
😎 Deploy Preview https://deploy-preview-791--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit bdc216c into main Dec 12, 2023
19 checks passed
@brandonroberts brandonroberts deleted the fix-vitest-reporters branch December 12, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant