Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-nitro): fix prerender from content directory #895

Merged

Conversation

remes2000
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

#894

Closes #

What is the new behavior?

The user can specify the contentDir with and without adding '/' as first character

Does this PR introduce a breaking change?

  • Yes
  • No

While setting up the content directory the user has access to "transform" property, that's a callback. The callback is being called with the object returned by getMatchingContentFilesWithFrontMatter as its argument. Property "path" used to be always starting with '/' as first character but it's not anymore. Right now it's a relative path from root to content directory. I think that's the expected behavior.

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 34bb2da
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/65ce637e365a84000883d633
😎 Deploy Preview https://deploy-preview-895--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 34bb2da
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/65ce637e545ea4000848737c
😎 Deploy Preview https://deploy-preview-895--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for analog-app failed.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65cf6e8dcc0df50bb18c71a0

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for analog-ng-app failed.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/65cf6e853a27100bcec5b642

@remes2000
Copy link
Contributor Author

I don't know why is the pipeline red, but I've noticed it was also red for this one: #893 so I assume that's not on me :D Let me know if I have to do anything

@brandonroberts brandonroberts merged commit 4434069 into analogjs:main Feb 16, 2024
14 of 23 checks passed
@brandonroberts
Copy link
Member

Thanks! @allcontributors add @remes2000 for code

Copy link
Contributor

@brandonroberts

I've put up a pull request to add @remes2000! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants