You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user can specify the contentDir with and without adding '/' as first character
Does this PR introduce a breaking change?
Yes
No
While setting up the content directory the user has access to "transform" property, that's a callback. The callback is being called with the object returned by getMatchingContentFilesWithFrontMatter as its argument. Property "path" used to be always starting with '/' as first character but it's not anymore. Right now it's a relative path from root to content directory. I think that's the expected behavior.
Other information
[optional] What gif best describes this PR or how it makes you feel?
I don't know why is the pipeline red, but I've noticed it was also red for this one: #893 so I assume that's not on me :D Let me know if I have to do anything
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
#894
Closes #
What is the new behavior?
The user can specify the contentDir with and without adding '/' as first character
Does this PR introduce a breaking change?
While setting up the content directory the user has access to "transform" property, that's a callback. The callback is being called with the object returned by
getMatchingContentFilesWithFrontMatter
as its argument. Property "path" used to be always starting with '/' as first character but it's not anymore. Right now it's a relative path from root to content directory. I think that's the expected behavior.Other information
[optional] What gif best describes this PR or how it makes you feel?