Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation with FallbackResource. #72

Merged
merged 1 commit into from Jan 14, 2014
Merged

Update documentation with FallbackResource. #72

merged 1 commit into from Jan 14, 2014

Conversation

malkusch
Copy link
Contributor

Apache encourages the use of FallbackResource instead of a rewrite rule.

@martinbean
Copy link
Collaborator

Hi Markus. Do you have link to a resource where Apache encourages the use of FallbackResource instead of a RewriteRule?

@malkusch
Copy link
Contributor Author

http://httpd.apache.org/docs/trunk/rewrite/remapping.html#fallback-resource

As of version 2.2.16, you should use the FallbackResource directive for this

@martinbean
Copy link
Collaborator

Neat tip, but I’m not comfortable with lowering the barrier of entry for users of ToroPHP by providing documentation that excludes users of older versions of Apache. Thoughts, @anandkunal?

@malkusch
Copy link
Contributor Author

This feature is 4 years old. There exists no maintained version which doesn't support that feature. Apache is not that kind of software you want to run a unmaintained version. Anyways… your decision.

martinbean added a commit that referenced this pull request Jan 14, 2014
Update documentation with FallbackResource.
@martinbean martinbean merged commit 5d8f4ba into anandkunal:master Jan 14, 2014
@martinbean
Copy link
Collaborator

If that’s the case and Apache >= 2.2.16 is in widespread use, then happy to mention it in documentation.

As I say, neat feature and I’ll look to use it myself in any Apache-hosted PHP apps (I work a lot with nginx these days), so thanks for bringing it to my attention!

@khromov
Copy link

khromov commented Jan 15, 2014

There exists a large userbase of older Apache installations - all CentOS 6 machines are running Apache/2.2.15

[root@s3 ~]# httpd -v
Server version: Apache/2.2.15 (Unix)

CentOS 6 and its commercial brother Red Hat Enterprise Linux are well-maintained and have over 30% market share amongst UNIX OS'es.
http://w3techs.com/technologies/details/os-linux/all/all

Apache actually errors out with an Internal Server Error when you use the FallbackResource.

I vote to revert the documentation change, since I think a large portion of web hosts can't use this. (Certainly not any vanilla CentOS or Red Hat installations.)

@martinbean
Copy link
Collaborator

This was exactly my hesitancy for merging this pull request. I’ll revert back at my earliest convenience, unless someone gets there before me.

martinbean added a commit that referenced this pull request Jan 15, 2014
This reverts commit 5d8f4ba, reversing
changes made to 470ae04.
@khromov
Copy link

khromov commented Jan 15, 2014

Thanks Martin.

I think the FallBack directive is actually excellent and elegant, and should be part of the documentation. But it should be alongside with the older, more supported method.

@malkusch
Copy link
Contributor Author

CentOS 6 and its commercial brother Red Hat Enterprise Linux are well-maintained

Regarding that mentioned market share. I really hope "well-maintained" means they distribute a patched 2.2.15 version with those 2.2.x upstream patches: http://httpd.apache.org/security/vulnerabilities_22.html

I just found that one: http://w3techs.com/technologies/details/ws-apache/2.2/all
It shows sadly that 2.2.15 is about the median of all used 2.2 version. So, yes I agree keep that RewriteRule. I'd suggest to mention that FallbackResource as well for people with a more recent apache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants