Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid-template-columns falsely identified as "multicolumn" feature #100

Closed
ultraq opened this issue Nov 21, 2018 · 5 comments
Closed

grid-template-columns falsely identified as "multicolumn" feature #100

ultraq opened this issue Nov 21, 2018 · 5 comments

Comments

@ultraq
Copy link

ultraq commented Nov 21, 2018

I wrote a style that uses grid-template-columns, but it gets marked as the CSS "multicolumn" feature: Unexpected browser feature "multicolumn" is only partially supported by Firefox 60,62,63 (output is from https://github.com/ismay/stylelint-no-unsupported-browser-features which uses this library under the hood).

Reading the How it works section, I read that a rather simple string matching is done using the data/features.js file, and looking through that file I can see that the word columns is associated with the the multicolumn feature: https://github.com/anandthakker/doiuse/blob/master/data/features.js#L80-L82

I'm not sure what your plans are for being able to distinguish between these kinds of features, but I thought you should know that it's having this effect 🙂

@totkeks
Copy link

totkeks commented Aug 28, 2019

Stumbled upon the same problem with stylelint just about now.

From what you write it seems that the string matcher should match full properties instead of just looking for words. so it should check for <start of word>columns:, which would match the multicolumns feature and not grid-template-columns:

@VBagmut
Copy link

VBagmut commented Nov 2, 2019

When it will be fixed?

@jgonera
Copy link

jgonera commented Aug 19, 2020

If you find adding stylelint-disable-next-line comments tiring as a workaround you can use:

grid-template: auto / 1fr 272px;

instead of

grid-template-columns: 1fr 272px;

and

grid-template: 1fr 272px / auto;

for rows.

@pkuczynski
Copy link
Collaborator

I would happily accept a PR if you have some time to work on it?

@clshortfuse
Copy link
Collaborator

Fixed in #159

echo 'body{grid-template-columns: auto;}' | npx doiuse --browsers "ie >= 8"
<streaming css input>:1:1: CSS Grid Layout (level 1) not supported by: IE (8,9) and only partially supported by: IE (10,11) (css-grid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants